Löschfristen: Probelauf, Bericht ans Team, Löschen nach drei Jahren
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
ClaudeandClaude Sonnet 5.5 committed
1 parent
cc42ab16c1
commit
9342ba10c8
5 files changed
+484
-1
No files matched your search
@@ -6,7 +6,7 @@ import { contractAttachmentFor, termsDocFor } from '../server/services/products.
|
||||
|
||||
const DIR = new URL('../server/mail-templates/', import.meta.url)
|
||||
// K12, K14 und T12 (Wechsel ins Wartungs-Abo) aus Task 9, K13 und T13 (Zusatzspeicher) aus Task 8 (Fix 1);
|
||||
// Endfassung der Texte in Task 12 (T14 „Löschfristen“ kommt mit Task 21 dazu)
|
||||
// Endfassung der Texte in Task 12; T14 „Löschfristen“ aus Task 21 (F39)
|
||||
const EXPECTED = [
|
||||
...Array.from({ length: 11 }, (_, i) => `K${String(i + 1).padStart(2, '0')}`),
|
||||
'K12',
|
||||
@@ -15,6 +15,7 @@ const EXPECTED = [
|
||||
...Array.from({ length: 11 }, (_, i) => `T${String(i + 1).padStart(2, '0')}`),
|
||||
'T12',
|
||||
'T13',
|
||||
'T14',
|
||||
]
|
||||
|
||||
const sampleValues = (tpl) => Object.fromEntries(tpl.placeholders.map((p) => [p, `Wert-${p}`]))
|
||||
|
||||
@@ -0,0 +1,207 @@
|
||||
import { test, after } from 'node:test'
|
||||
import assert from 'node:assert/strict'
|
||||
import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
||||
import os from 'node:os'
|
||||
import path from 'node:path'
|
||||
import { startAppwriteMock } from './support/appwriteMock.js'
|
||||
import { startFakeStripe } from './support/fakeStripe.js'
|
||||
import { useTestEnv } from './support/testEnv.js'
|
||||
import { schemaKeys } from './support/schema.js'
|
||||
import { mailSink } from './support/mailSink.js'
|
||||
|
||||
// Nachbauten und temporaerer Upload-Ordner (F41d), BEVOR config.js geladen wird
|
||||
const aw = await startAppwriteMock({
|
||||
schema: {
|
||||
subscriptions: schemaKeys('subscriptions'),
|
||||
contractEvents: schemaKeys('contractEvents'),
|
||||
takeoverCredits: schemaKeys('takeoverCredits'),
|
||||
},
|
||||
})
|
||||
const st = await startFakeStripe()
|
||||
const uploadDir = mkdtempSync(path.join(os.tmpdir(), 'loeschfristen-'))
|
||||
process.env.TAKEOVER_UPLOAD_DIR = uploadDir
|
||||
useTestEnv({ appwriteUrl: aw.url, stripeUrl: st.url })
|
||||
const { findDueDeletions, applyDeletions, CONSENT_METADATA_KEYS } = await import('../server/services/retention.js')
|
||||
const { run } = await import('../scripts/loeschfristen.mjs')
|
||||
const { stripeSubscription } = await import('./support/fixtures.js')
|
||||
const { setMailTransportForTests } = await import('../server/services/mailer.js')
|
||||
|
||||
const mails = mailSink()
|
||||
setMailTransportForTests(mails)
|
||||
after(() => {
|
||||
setMailTransportForTests(null)
|
||||
rmSync(uploadDir, { recursive: true, force: true })
|
||||
return Promise.all([aw.close(), st.close()])
|
||||
})
|
||||
|
||||
// 01.01.2026, 12:00 Berlin
|
||||
const JAN_2026 = new Date('2026-01-01T12:00:00+01:00')
|
||||
const DEC_2025 = new Date('2025-12-31T12:00:00+01:00')
|
||||
|
||||
const sub = (id, customerId, fields) => aw.seed('subscriptions', { $id: id, stripeSubscriptionId: id, customerId, ...fields })
|
||||
const event = (id, customerId, subscriptionId) =>
|
||||
aw.seed('contractEvents', { $id: id, customerId, subscriptionId, type: 'abschluss', status: 'erledigt', consentIp: '10.0.0.1', consentUserAgent: 'x' })
|
||||
const stripeSub = (id, customerId, extra = {}) => st.subscriptions.set(id, stripeSubscription({ id, customerId, status: 'canceled', ...extra }))
|
||||
const dueIds = (plan) => plan.customers.map((c) => c.customerId).sort()
|
||||
|
||||
test('Abo beendet am 15.03.2022: fällig am 01.01.2026, nicht am 31.12.2025', async () => {
|
||||
sub('r1_sub', 'r1', { status: 'canceled', endedAt: '2022-03-15T10:00:00.000Z' })
|
||||
event('r1_ev', 'r1', 'r1_sub')
|
||||
assert.ok(!dueIds(await findDueDeletions(DEC_2025)).includes('r1'))
|
||||
const plan = await findDueDeletions(JAN_2026)
|
||||
const entry = plan.customers.find((c) => c.customerId === 'r1')
|
||||
assert.deepEqual(entry, { customerId: 'r1', lastEndAt: '2022-03-15T10:00:00.000Z', subscriptionIds: ['r1_sub'], eventIds: ['r1_ev'] })
|
||||
})
|
||||
|
||||
test('Ende zählt in deutscher Zeit: 31.12.2021 23:30 UTC ist schon 2022', async () => {
|
||||
sub('r1b_sub', 'r1b', { status: 'canceled', endedAt: '2021-12-31T23:30:00.000Z' })
|
||||
assert.ok(!dueIds(await findDueDeletions(DEC_2025)).includes('r1b'))
|
||||
assert.ok(dueIds(await findDueDeletions(JAN_2026)).includes('r1b'))
|
||||
})
|
||||
|
||||
test('Abo beendet vor zwei Jahren: nicht fällig', async () => {
|
||||
sub('r2_sub', 'r2', { status: 'canceled', endedAt: new Date(JAN_2026.getTime() - 2 * 365 * 86400000).toISOString() })
|
||||
assert.ok(!dueIds(await findDueDeletions(JAN_2026)).includes('r2'))
|
||||
})
|
||||
|
||||
test('altes beendetes Abo und ein laufendes Abo desselben Kunden: nicht fällig', async () => {
|
||||
sub('r3_old', 'r3', { status: 'canceled', endedAt: '2019-05-01T00:00:00.000Z' })
|
||||
sub('r3_new', 'r3', { status: 'active', endedAt: null })
|
||||
assert.ok(!dueIds(await findDueDeletions(JAN_2026)).includes('r3'))
|
||||
})
|
||||
|
||||
test('das letzte Ende zählt; Ende = endedAt, sonst canceledAt, sonst currentPeriodEnd bei canceled', async () => {
|
||||
sub('r4_a', 'r4', { status: 'canceled', endedAt: '2018-01-01T00:00:00.000Z' })
|
||||
sub('r4_b', 'r4', { status: 'canceled', endedAt: null, canceledAt: '2022-06-01T00:00:00.000Z', currentPeriodEnd: '2010-01-01T00:00:00.000Z' })
|
||||
sub('r5_a', 'r5', { status: 'canceled', endedAt: null, canceledAt: null, currentPeriodEnd: '2022-02-01T00:00:00.000Z' })
|
||||
sub('r6_a', 'r6', { status: 'past_due', endedAt: null, canceledAt: null, currentPeriodEnd: '2010-02-01T00:00:00.000Z' })
|
||||
const plan = await findDueDeletions(JAN_2026)
|
||||
const r4 = plan.customers.find((c) => c.customerId === 'r4')
|
||||
assert.equal(r4.lastEndAt, '2022-06-01T00:00:00.000Z')
|
||||
assert.deepEqual(r4.subscriptionIds.sort(), ['r4_a', 'r4_b'])
|
||||
assert.ok(dueIds(plan).includes('r5'))
|
||||
assert.ok(!dueIds(plan).includes('r6'), 'nicht beendet (past_due) zählt nicht')
|
||||
})
|
||||
|
||||
test('applyDeletions: löscht Dokumente, leert alle Zustimmungs-Metadaten bei Stripe, lässt Rechnungen und andere Kunden', async () => {
|
||||
sub('a1_sub', 'a1', { status: 'canceled', endedAt: '2021-01-10T00:00:00.000Z' })
|
||||
event('a1_ev', 'a1', 'a1_sub')
|
||||
event('a1_ev2', 'a1', 'a1_sub')
|
||||
sub('a2_sub', 'a2', { status: 'active' })
|
||||
event('a2_ev', 'a2', 'a2_sub')
|
||||
stripeSub('a1_sub', 'a1', {
|
||||
metadata: { switchedAt: '2021-01-01', switchedFrom: 'hosting' },
|
||||
})
|
||||
st.invoices.set('in_a1', { id: 'in_a1', object: 'invoice', subscription: 'a1_sub' })
|
||||
const callsBefore = st.calls.length
|
||||
const plan = await findDueDeletions(JAN_2026)
|
||||
assert.ok(plan.customers.some((c) => c.customerId === 'a1'))
|
||||
const result = await applyDeletions({ customers: plan.customers.filter((c) => c.customerId === 'a1'), takeover: [] })
|
||||
assert.deepEqual(result.manual, [])
|
||||
assert.equal(result.deleted.subscriptions, 1)
|
||||
assert.equal(result.deleted.contractEvents, 2)
|
||||
assert.ok(!aw.docs('subscriptions').has('a1_sub'))
|
||||
assert.ok(!aw.docs('contractEvents').has('a1_ev') && !aw.docs('contractEvents').has('a1_ev2'))
|
||||
assert.ok(aw.docs('subscriptions').has('a2_sub') && aw.docs('contractEvents').has('a2_ev'))
|
||||
const update = st.calls.slice(callsBefore).find((c) => c.method === 'POST' && c.path === '/v1/subscriptions/a1_sub')
|
||||
assert.ok(update, 'Stripe-Abo wurde geändert')
|
||||
for (const key of CONSENT_METADATA_KEYS) assert.equal(update.body[`metadata[${key}]`], '', `${key} geleert`)
|
||||
assert.deepEqual(CONSENT_METADATA_KEYS.slice().sort(), [
|
||||
'consentIp', 'consentTextVersion', 'consentUserAgent', 'earlyStartConsentAt', 'startChoice', 'switchedAt', 'switchedFrom', 'termsAcceptedAt', 'termsVersion',
|
||||
])
|
||||
const meta = st.subscriptions.get('a1_sub').metadata
|
||||
for (const key of CONSENT_METADATA_KEYS) assert.ok(!(key in meta), `${key} weg`)
|
||||
assert.equal(meta.webklarCustomerId, 'a1', 'übrige Angaben (Zuordnung) bleiben')
|
||||
assert.ok(st.invoices.has('in_a1'), 'Rechnungen bleiben')
|
||||
})
|
||||
|
||||
test('abgelehnte Stripe-Änderung landet in manual, die Appwrite-Dokumente werden trotzdem gelöscht', async () => {
|
||||
sub('m1_sub', 'm1', { status: 'canceled', endedAt: '2020-02-02T00:00:00.000Z' })
|
||||
event('m1_ev', 'm1', 'm1_sub')
|
||||
stripeSub('m1_sub', 'm1')
|
||||
st.failNext({ method: 'POST', path: '/v1/subscriptions/m1_sub', status: 400, message: 'A canceled subscription can only update its cancellation_details.' })
|
||||
const result = await applyDeletions({
|
||||
customers: [{ customerId: 'm1', lastEndAt: '2020-02-02T00:00:00.000Z', subscriptionIds: ['m1_sub'], eventIds: ['m1_ev'] }],
|
||||
takeover: [],
|
||||
})
|
||||
assert.equal(result.manual.length, 1)
|
||||
assert.equal(result.manual[0].subscriptionId, 'm1_sub')
|
||||
assert.equal(result.manual[0].customerId, 'm1')
|
||||
assert.match(result.manual[0].reason, /canceled subscription/)
|
||||
assert.ok(!aw.docs('subscriptions').has('m1_sub') && !aw.docs('contractEvents').has('m1_ev'))
|
||||
assert.ok('consentIp' in st.subscriptions.get('m1_sub').metadata, 'bei Stripe unverändert, Hinweis im Bericht')
|
||||
})
|
||||
|
||||
test('Übernahme-Anträge: abgelehnte nur melden, genehmigte erst nach 8 Jahren ab Jahresende löschen', async () => {
|
||||
const withFiles = (id) => {
|
||||
mkdirSync(path.join(uploadDir, id), { recursive: true })
|
||||
writeFileSync(path.join(uploadDir, id, 'nachweis.pdf'), 'x')
|
||||
return JSON.stringify([{ id: 'f1', name: 'nachweis.pdf' }])
|
||||
}
|
||||
const tc = (id, fields) => aw.seed('takeoverCredits', { $id: id, customerId: 't1', ...fields })
|
||||
// abgelehnt vor >6 Monaten, Nachweise noch da (tägliche Bereinigung hat sie nicht erwischt): nur melden
|
||||
tc('tk_rej', { status: 'abgelehnt', decidedAt: '2025-05-01T00:00:00.000Z', files: withFiles('tk_rej') })
|
||||
// abgelehnt, Nachweise schon gelöscht: nichts zu melden
|
||||
tc('tk_rej_clean', { status: 'abgelehnt', decidedAt: '2025-05-01T00:00:00.000Z', files: '[]' })
|
||||
// genehmigt 2017: Frist endet mit Ablauf 2025 (8 Jahre ab Jahresende 2017), am 01.01.2026 fällig
|
||||
tc('tk_old', { status: 'genehmigt', decidedAt: '2017-11-20T00:00:00.000Z', files: withFiles('tk_old') })
|
||||
// genehmigt 2018: erst am 01.01.2027 fällig
|
||||
tc('tk_2018', { status: 'genehmigt', decidedAt: '2018-03-01T00:00:00.000Z', files: withFiles('tk_2018') })
|
||||
tc('tk_open', { status: 'offen', files: withFiles('tk_open') })
|
||||
const plan = await findDueDeletions(JAN_2026)
|
||||
const byId = Object.fromEntries(plan.takeover.map((t) => [t.id, t]))
|
||||
assert.deepEqual(Object.keys(byId).sort(), ['tk_old', 'tk_rej'])
|
||||
assert.equal(byId.tk_rej.action, 'melden')
|
||||
assert.match(byId.tk_rej.reason, /abgelehnt/)
|
||||
assert.equal(byId.tk_old.action, 'loeschen')
|
||||
assert.match(byId.tk_old.reason, /acht Jahre|8 Jahre/)
|
||||
|
||||
const result = await applyDeletions({ customers: [], takeover: plan.takeover })
|
||||
assert.equal(result.deleted.takeover, 1)
|
||||
assert.ok(aw.docs('takeoverCredits').has('tk_rej') && existsSync(path.join(uploadDir, 'tk_rej')), 'abgelehnter Antrag bleibt der täglichen Bereinigung überlassen')
|
||||
assert.ok(!aw.docs('takeoverCredits').has('tk_old') && !existsSync(path.join(uploadDir, 'tk_old')))
|
||||
assert.ok(aw.docs('takeoverCredits').has('tk_2018') && existsSync(path.join(uploadDir, 'tk_2018')))
|
||||
// 2027: auch 2018 ist fällig
|
||||
const later = await findDueDeletions(new Date('2027-01-02T12:00:00+01:00'))
|
||||
assert.ok(later.takeover.some((t) => t.id === 'tk_2018' && t.action === 'loeschen'))
|
||||
})
|
||||
|
||||
test('Skript: Probelauf ändert nichts und schickt nichts', async () => {
|
||||
sub('s1_sub', 's1', { status: 'canceled', endedAt: '2021-03-03T00:00:00.000Z' })
|
||||
event('s1_ev', 's1', 's1_sub')
|
||||
stripeSub('s1_sub', 's1')
|
||||
const callsBefore = st.calls.length
|
||||
const sentBefore = mails.sent.length
|
||||
const lines = []
|
||||
const result = await run({ mode: '', now: JAN_2026, log: (l) => lines.push(l) })
|
||||
assert.equal(result.applied, false)
|
||||
assert.ok(aw.docs('subscriptions').has('s1_sub') && aw.docs('contractEvents').has('s1_ev'))
|
||||
assert.equal(st.calls.length, callsBefore)
|
||||
assert.equal(mails.sent.length, sentBefore)
|
||||
const text = lines.join('\n')
|
||||
assert.match(text, /Probelauf/)
|
||||
assert.match(text, /s1/)
|
||||
})
|
||||
|
||||
test('Skript: LOESCHFRISTEN=mail schickt den Bericht als T14 ans Team, löscht nichts', async () => {
|
||||
const sentBefore = mails.sent.length
|
||||
const result = await run({ mode: 'mail', now: JAN_2026, log: () => {} })
|
||||
assert.equal(result.applied, false)
|
||||
assert.equal(mails.sent.length, sentBefore + 1)
|
||||
const mail = mails.sent.at(-1)
|
||||
assert.match(mail.subject, /^\[Datenschutz\] Löschfristen fällig/)
|
||||
assert.match(mail.text, /s1/)
|
||||
assert.match(mail.text, /Probelauf|Vorschau/)
|
||||
assert.ok(aw.docs('subscriptions').has('s1_sub'))
|
||||
})
|
||||
|
||||
test('Skript: LOESCHFRISTEN=apply löscht', async () => {
|
||||
const result = await run({ mode: 'apply', now: JAN_2026, log: () => {} })
|
||||
assert.equal(result.applied, true)
|
||||
assert.ok(!aw.docs('subscriptions').has('s1_sub') && !aw.docs('contractEvents').has('s1_ev'))
|
||||
assert.ok(aw.docs('subscriptions').has('a2_sub'), 'laufendes Abo bleibt')
|
||||
})
|
||||
|
||||
test('Skript: unbekannter Modus wird abgelehnt', async () => {
|
||||
await assert.rejects(run({ mode: 'loeschen', now: JAN_2026, log: () => {} }), /LOESCHFRISTEN/)
|
||||
})
|
||||
Reference in new issue
Block a user